Reduce default fees #4507
Merged
Reduce default fees #4507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make it clearer what we're doing, IMHO, so we can easily alter the levels if we want. Signed-off-by: Rusty Russell <[email protected]>
niftynei
approved these changes
May 5, 2021
plugins/bcli.c
Outdated
|
|
||
| /* | ||
| * Calls `estimatesmartfee` with targets 2/CONSERVATIVE (very urgent), | ||
| * 3/CONSERVATIVE (urgent), 4/ECONOMICAL (normal), and 100/ECONOMICAL (slow) |
There was a problem hiding this comment.
this comment should be updated in your next commit
There was a problem hiding this comment.
I deleted it. The code is now clear, and the comment just risks getting outdated again.
Users are more upset recently with the cost of unilateral closes than they are the risk of being cheated. While we complete our anchor implementation so we can use low fees there, let's get less aggressive (we already have 34 or 18 blocks to close in the worst case). The changes are: - Commit transactions were "2 CONSERVATIVE" now "6 ECONOMICAL". - HTLC resolution txs were "3 CONSERVATIVE" now "6 ECONOMICAL". - Penalty txs were "3 CONSERVATIVE" now "12 ECONOMICAL". - Normal txs were "4 ECONOMICAL" now "12 ECONOMICAL". There can be no perfect levels, but we have had understandable complaints recently about how high our default fee levels are. Changelog-Changed: Protocol: channel feerates reduced to bitcoind's "6 block ECONOMICAL" rate. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
guilt/reduce-fees
branch
from
19e89fc
to
5d8f3e2
Compare
Log this so I can try to find dual fund connnectd race. Signed-off-by: Rusty Russell <[email protected]>
|
OK, this is tripping dualopend confusion with connectd getting desynchronized on disconnect messages. Adding debugging now... |
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 6, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 6, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 11, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 12, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 14, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 17, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 20, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 25, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 25, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 26, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 26, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 26, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 27, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 30, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
added a commit
to vincenzopalazzo/lightning
that referenced
this pull request
May 30, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR ElementsProject#4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
rustyrussell
pushed a commit
that referenced
this pull request
May 31, 2021
This commit introduces the code cleanup suggested by the TODO comment in the code. Basically, it moves the code from the if-else statement to a switch statement without the default case. I used the basic idea of the code used in PR #4507. Changelog-Changed: None. Signed-off-by: Vincenzo Palazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.